ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land.
+1 to making this hidden. Users (most of them) shouldn't care about it. Is there any motivation on why we someone would want to disable it currently? Maybe we want to deprecate it and remove it completely at some point? I could only think of being as close as possible to sema completions, but that doesn't seem like something that gives better UX (folks from Apple might be interested in that, but not sure). LGTM from my side. ================ Comment at: clangd/tool/ClangdMain.cpp:135 + "Enable index-based features. By default, clangd maintains an index " + "built from symbols in opened files. Static/global index support needs " + "to enabled separatedly."), ---------------- Maybe replace static/global with simply "Global" or "Project-wide". I think it's good that we don't mention "dynamic" and "static" index in the docs too much, users shouldn't really care about this terminology. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51977 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
