delesley accepted this revision. delesley added a comment. This revision is now accepted and ready to land.
This looks okay to me, but I have not tested it on a large code base to see if it breaks anything. ================ Comment at: lib/Sema/SemaDeclAttr.cpp:589 + << AL << MD->getParent(); + } else + S.Diag(AL.getLoc(), diag::warn_thread_attribute_not_on_non_static_member) ---------------- Curly braces around the else section. Repository: rC Clang https://reviews.llvm.org/D51901 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits