sammccall requested changes to this revision.
sammccall added a comment.
This revision now requires changes to proceed.
This change does several things, and I think most of them need further thought.
Can we discuss Monday?
================
Comment at: clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp:96
-static void DexQueries(benchmark::State &State) {
+// This is not a *real* benchmark: it shows size of built MemIndex (in bytes).
+// Same for the next "benchmark".
----------------
This looks like it'll be really stable, why does it need to be a benchmark vs
say a dexp subcommand?
https://reviews.llvm.org/D52047
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
