george.karpenkov requested changes to this revision. george.karpenkov added a comment. This revision now requires changes to proceed. Herald added a subscriber: donat.nagy.
Great idea, thanks! Should be good to go once examples are added, and implicit checks are removed. ================ Comment at: www/analyzer/available_checks.html:770 +(ObjC)</span><div class="descr"> +Check for proper uses of Objective-C properties</div></div></td> +<td><div class="exampleContainer expandable"> ---------------- `proper uses` is not particularly descriptive? ================ Comment at: www/analyzer/available_checks.html:884 +<div class="example"><pre> +<!-- TODO: Add an example. --> +</pre></div></div></td></tr> ---------------- Yep, not very useful without an example. I'm pretty sure the code and tests have one. ================ Comment at: www/analyzer/available_checks.html:988 +<!-- TODO: Is this an implicit checker? --> +<tr><td><div class="namedescr expandable"><span class="name"> ---------------- Yeah, doesn't seem useful to the user. https://reviews.llvm.org/D53069 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
