hans added inline comments.
================ Comment at: clang/lib/AST/ASTContext.cpp:9552 + // overwrite linkage of explicit template instantiation + // definition/declaration. + return GVA_DiscardableODR; ---------------- takuto.ikuta wrote: > takuto.ikuta wrote: > > hans wrote: > > > Can you give an example for why this is needed? > > Sorry, this change does not need. Removed. > Sorry, this change is necessary still. > > Without this, definition of inline function in explicit template > instantiation declaration is not be emitted, due to GVA_AvailableExternally > linkage. > But we stop exporting definition of inline function in explicit template > instantiation definition too. > > So without this, definition of dllimported inline function of explicit > template instantiation declaration won't be available. > Can you provide a code example of why this is needed? https://reviews.llvm.org/D51340 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
