aprantl added a comment.

> I think the only way to realistically make this work for all platforms would 
> be to separate the source file from the input/output. The source file would 
> be the test case, and if you wanted to support a different debugger you would 
> need to supply a different input/output file..

I don't necessarily agree with that statement. The debuginfo-tests use only a 
very small subset of debugger functionality that includes

- setting breakpoints
- printing the value of integer variables
- continuing to the next breakpoint

I'm genuinely curious what is so different about the Windows debugger that it 
couldn't be wrapped in a translation layer like `llgdb.py` that abstracts these 
three operations. This would cover a large set of the existing tests. I'm fine 
with having a few extra tests that test something that only works on a specific 
platform here and there, but I really don't want us to grow separate 
platform-specific testsuites. Inevitably, someone working on platform A will 
fix a general bug in LLVM and then only add a test for platform A and that's 
bad for everyone. What I'm trying to avoid is a situation like the debug info 
tests in LLVM that are almost entirely x86-specific, even if they are testing 
stuff that happens at the IR level.


https://reviews.llvm.org/D54187



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to