JonasToth added inline comments.

================
Comment at: 
clang-tidy/cppcoreguidelines/ProBoundsArrayToPointerDecayCheck.cpp:65
+          unless(isInsideOfRangeBeginEndStmt()),
+          unless(hasSourceExpression(ignoringParenCasts(stringLiteral()))))
           .bind("cast"),
----------------
aaron.ballman wrote:
> I think you want `ignoringParens()` instead, no?
That doesn't seem to compile, it only applies to `QualType`. There is 
`ignoringParenCasts` and `ignoringParenImpCasts` that match on everything. 
Ignoring the imp-casts is not what we want.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D54281



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to