aaron.ballman added inline comments.
================ Comment at: clang-tidy/cppcoreguidelines/ProBoundsArrayToPointerDecayCheck.cpp:65 + unless(isInsideOfRangeBeginEndStmt()), + unless(hasSourceExpression(ignoringParenCasts(stringLiteral())))) .bind("cast"), ---------------- JonasToth wrote: > aaron.ballman wrote: > > I think you want `ignoringParens()` instead, no? > That doesn't seem to compile, it only applies to `QualType`. There is > `ignoringParenCasts` and `ignoringParenImpCasts` that match on everything. > Ignoring the imp-casts is not what we want. Neither is ignoring the paren casts because that covers actual casts like reinterpret_cast. There is an `Expr::IgnoreParens()`, so I'm betting that the `ignoringParens()` matcher just needs an overload for `Expr`. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54281 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits