martong marked 2 inline comments as done.
martong added inline comments.

================
Comment at: test/Analysis/ctu-main.c:4
+// RUN: %clang_cc1 -triple x86_64-pc-linux-gnu -emit-pch -o 
%t/ctudir2/ctu-other.c.ast %S/Inputs/ctu-other.c
+// RUN: cp %S/Inputs/externalFnMap2.txt %t/ctudir2/externalFnMap.txt
+// RUN: %clang_cc1 -triple x86_64-pc-linux-gnu -fsyntax-only -std=c89 -analyze 
-analyzer-checker=core,debug.ExprInspection  -analyzer-config 
experimental-enable-naive-ctu-analysis=true -analyzer-config ctu-dir=%t/ctudir2 
-verify %s
----------------
Szelethus wrote:
> martong wrote:
> > Szelethus wrote:
> > > This is a question rather than anything else, why do we have both 
> > > externalFnMap2.txt and externalFnMap.txt?
> > `externalFnMap.txt` goes for `ctu-other.cpp`.
> > `externalFnMap2.txt` goes for `ctu-other.c`.
> > Perhaps we should rename them in the `Inputs` directory to include the 
> > indexed file name. E.g. `ctu-other.cpp.externalFnMap.txt`. What do you 
> > think?
> Sounds great! :)
Ok, I have renamed the ExternalFnMap files.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55131/new/

https://reviews.llvm.org/D55131



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to