martong marked an inline comment as done. martong added inline comments.
================ Comment at: lib/CrossTU/CrossTranslationUnit.cpp:247 llvm::Expected<const FunctionDecl *> CrossTranslationUnitContext::importDefinition(const FunctionDecl *FD) { ASTImporter &Importer = getOrCreateASTImporter(FD->getASTContext()); ---------------- TODO: add a comment that this function never returns with nullptr on success. And consequently `CrossTranslationUnitContext::getCrossTUDefinition` neither. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55131/new/ https://reviews.llvm.org/D55131 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits