hubert.reinterpretcast added a subscriber: rsmith.
hubert.reinterpretcast added inline comments.
================
Comment at: clang/lib/Basic/Targets/OSTargets.h:626
+
+ // FIXME: Define AIX OS-Version Macros
+ Builder.defineMacro("_AIX");
----------------
Comments should be full sentences (with periods). Please update throughout this
patch.
================
Comment at: clang/lib/Basic/Targets/OSTargets.h:629
+
+ // FIXME: Determine the proper way for users to select the no-long-long
+ // version of the standard library
----------------
@rsmith suggested that having a `-fno-long-long` option to disable support for
long long would be preferable to having an `-maix-no-long-long` that just
controls the AIX binary-compatibility aspects. Perhaps the FIXME should be
updated to mention checking `-fno-long-long`.
================
Comment at: clang/lib/Basic/Targets/OSTargets.h:637
+
+ // Define _WCHAR_T only for C++
+ if (Opts.CPlusPlus && Opts.WChar) {
----------------
Suggestion for the comment text:
Define `_WCHAR_T` when it is a fundamental type (i.e., for C++ without
`-fno-wchar`).
================
Comment at: clang/lib/Basic/Targets/OSTargets.h:641
+ }
+ }
+
----------------
D18360 sets `_THREAD_SAFE` to `1` when `-pthread` is specified. I believe that
to be correct. I believe whether or not `-pthread` is taken to be the default
on the platform is a separate consideration.
================
Comment at: clang/lib/Basic/Targets/OSTargets.h:651
+ }
+ this->UseZeroLengthBitfieldAlignment = true;
+ }
----------------
Can we have a test for this?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59048/new/
https://reviews.llvm.org/D59048
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
