apaprocki added inline comments.
================
Comment at: clang/lib/Basic/Targets/OSTargets.h:626
+
+ // FIXME: Define AIX OS-Version Macros
+ Builder.defineMacro("_AIX");
----------------
hubert.reinterpretcast wrote:
> Comments should be full sentences (with periods). Please update throughout
> this patch.
I do not think it is realistic to support an AIX target prior to 7.1, so should
this unconditionally define up to and including `_AIX71` similar to D18360 did
(it was written earlier and defined up to `_AIX61` unconditionally) and leave a
`FIXME` to determine when to emit `_AIX72` or any other later versions?
================
Comment at: clang/test/Preprocessor/init.c:6420
+// PPC64-AIX:#define _LONG_LONG 1
+// PPC64-AIX:#define _POWER 1
+// PPC64-AIX:#define __64BIT__ 1
----------------
XL on AIX emits `#define _LP64 1` in 64-bit mode and `#define _ILP32 1` in
32-bit mode in the pre-defined macros. Is that important to capture?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59048/new/
https://reviews.llvm.org/D59048
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
