boga95 marked an inline comment as done. boga95 added a comment. Why is it better not to use `static` functions/variables? Has it any performance impact?
================ Comment at: lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:73-75 static const unsigned InvalidArgIndex = UINT_MAX; /// Denotes the return vale. static const unsigned ReturnValueIndex = UINT_MAX - 1; ---------------- Szelethus wrote: > We should definitely change these, not only is the large integer number > impossible to remember, but this value could differ on different platforms. I tried to use int, but I got a lot of warnings because of the `getNumArgs()` returns an unsigned value. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59555/new/ https://reviews.llvm.org/D59555 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
