Szelethus added a comment. In D59555#1442331 <https://reviews.llvm.org/D59555#1442331>, @boga95 wrote:
> Why is it better not to use `static` functions/variables? Has it any > performance impact? I don't think so, I just think that it's easier to follow what's happening with a non-static field. Also, I just don't see why it needs to be static, you only use `GenericTaintChecker::Custom*` where you could easily access it. Especially `GenericTaintChecker::getConfiguration` -- if it wasn't static, you wouldn't even need to take the checker as a parameter. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59555/new/ https://reviews.llvm.org/D59555 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
