Szelethus added a reviewer: Szelethus. Szelethus added a comment. In D59934#1446051 <https://reviews.llvm.org/D59934#1446051>, @gamesh411 wrote:
> Hi! > > This issue came up during the generation BugReports of BugPaths containing > macro-expansions, where the spelling location and expansion locations were in > different files. > With this change, we make such SourceLocations comparable by their FileIDs. Do you mean regular macro expansions or the one we're generating in the plist output via `-analyzer-config expand-macros=true`? ================ Comment at: lib/Basic/SourceManager.cpp:1984 /// Determines the order of 2 source locations in the translation unit. /// ---------------- We should change this too. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59934/new/ https://reviews.llvm.org/D59934 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
