ztamas added a comment. In D59870#1446537 <https://reviews.llvm.org/D59870#1446537>, @JonasToth wrote:
> > I think it's the easiest way to specify the bits of the ineteger type to > > limit the catches. In real life, I met with this overflow / infinite loop > > problem with 16-bit short type, so I think the real use cases are 8 and 16 > > bit integers. It seems intuitive to me to use the size of the loop > > variable's type to separate those catches which can lead broken > > functionality in practice from those use cases which are just integer > > incompatibilities. > > Given your experience and the false positive rate in some projects, should we > maybe default to 16 for that option? Seems a good idea. I'll update the code accordingly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59870/new/ https://reviews.llvm.org/D59870 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
