JonasToth added inline comments.
================ Comment at: clang-tools-extra/docs/ReleaseNotes.rst:124 + <clang-tidy/checks/bugprone-too-small-loop-variable>` now supports + `MagnitudeBitsUpperLimit` option. + ---------------- Please add the new default here as its a change in behaviour of the check. ================ Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-too-small-loop-variable.rst:33 + + Upper limit for the magnitue bits of the loop variable. If it's set the check + filters out those catches in which the loop variable's type has more magnitude ---------------- typo `magnitude` The commit you reference to the project fixing the "bugs" stated, that the version without conversions is more efficient (by one instruction :)). I think this might be worth a note, that even though the code is not a bug in itself it might still be preferable to remove those code locations in the long run. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59870/new/ https://reviews.llvm.org/D59870 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
