aaron.ballman added inline comments.
================
Comment at: clang-tools-extra/clang-tidy/llvm/AvoidCastInConditionalCheck.cpp:18
+
+AST_MATCHER(Expr, isMacroID) { return Node.getExprLoc().isMacroID(); }
+} // namespace ast_matchers
----------------
hintonda wrote:
> @aaron.ballman: This matcher seems genuinely useful. What do you think
> about moving it to ASTMatchers.h?
I think that adding something like this might be a good idea. We don't have any
notion of source locations in the AST matching syntax currently, and I'm not
certain whether that's a good thing or not here. I'm mildly uncomfortable that
this matcher operates on an `Expr` but then internally uses a source location
from that expression and I wonder if we would rather introduce source location
matching. For instance, what if the user cares about the difference between
`getExprLoc()` and `getBeginLoc()` for some reason?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59802/new/
https://reviews.llvm.org/D59802
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
