craig.topper added a comment.
We seem to be missing test cases in test/Driver/x86-target-feature.c to test
the command line options work. And test/Preprocessor/x86_target_features.c to
make sure -mavx512bf16 enables avx512vl and avx512bw. Also need tests to make
sure "-mavx512bf16 -mno-avx512bw" will leave bf16 disabled. Same for
"-mavx512bf16 -mno-avx512vl"
================
Comment at: lib/Basic/Targets/X86.cpp:667
if (Name == "avx512bw" && !Enabled)
Features["avx512vbmi"] = Features["avx512vbmi2"] =
Features["avx512bitalg"] = false;
----------------
Need to also disable avx512fp16 when we disable "avx512vbmi" and "avx512vbmi2".
Need a new if to disable "avx512fp16" when "if (Name == "avx512vl" && !Enabled)"
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60552/new/
https://reviews.llvm.org/D60552
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
