jakehehrlich added a comment. With respect to group handeling. I think we should just check that the details of every symbol across all unmerged files that are being merged are consistent and then ignore duplicates.
For symbols that are not defined in sections that are a part of a comdat group this is just delaying the error to the linker. For symbols defined in a comdat group this is the only way we can be consistent with whatever choice the linker makes. In practice every comdat group is the same but if it were different the linker is allowed to just pick one arbitrarily. The only way to be consistent is to ensure that duplicates are identical. This however means we ignore duplicate definitions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
