anton-afanasyev added a comment. In D63325#1549316 <https://reviews.llvm.org/D63325#1549316>, @lebedev.ri wrote:
> Hmm, i'm only now noticing how fraglie this looks. > How do we know that `clang::ParseAST` will only ever be called with > `BackendConsumer` `ASTConsumer`? > How do we know that `BackendConsumer` will only ever be `ASTConsumer` from > `clang::ParseAST`? This could be true by design. But I agree it's fragile. We can admit several `Frontend` sections though. But with this admission first variant with two `Frontend` `TimeTraceScope`'s is more preferrable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63325/new/ https://reviews.llvm.org/D63325 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
