anton-afanasyev added a comment. In D63325#1553458 <https://reviews.llvm.org/D63325#1553458>, @lebedev.ri wrote:
> Hm, i started writing previous comment before you posted your last comment, > so i didn't see the last update. > This looks less intrusive, yes, but two observations: > > 1. You now have two `"Frontend"` sections - first one being for lexing time > 2. That lexing section is not within the `"Frontend"` section, even though it > is for sure part of frontend of the compiler. Like i said, i'm not sure what > the right solution here is. Why lexing section is not within `"Frontend"` section. Your p.1 claims is is within. For now, first `"Frontend"` section includes lexing as well as frontend codegen (called from `Consumer->HandleTopLevelDecl()`. Second `"Frontend"` section includes only frontend codegen through `HandleTranslationUnit()` calling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63325/new/ https://reviews.llvm.org/D63325 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
