sammccall added a comment. So I've stared at this refactoring for a while, and I still don't totally get it. It seems like a class that really wants to be a function. It's a complicated function though - maybe a separate cpp file does make sense.
We discussed moving ShardVersions and Writes into the loader, splitting ShardVersions from IndexSymbols seems pretty odd though. What's the advantage of making this stateful? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64712/new/ https://reviews.llvm.org/D64712 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
