sammccall added inline comments.
================ Comment at: clang-tools-extra/clangd/index/BackgroundIndexLoader.cpp:47 + // Stores the absolute paths for the direct dependencies of this file. + std::vector<Path> Edges; + }; ---------------- I think we only need to traverse this when *missing* the cache, so it can be a return value of loadShard rather than stored in CachedShard (so CachedShard becomes just LoadedShard) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64712/new/ https://reviews.llvm.org/D64712 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
