hans added a comment.

I will try to take a look, but can you please expand the patch description a 
little to make it more clear exactly what you're proposing to change? Sorry for 
all the questions below, I'm just trying to understand exactly what the issue 
is.

> Previously, -fdiagnostics-absolute-paths did not have an effect in some 
> cases, for example: when using relative include paths, or relative CPP paths

Are you saying the diagnostics were not using absolute paths in those cases and 
this patch fixes that?

> , or --show-includes, or -E

Those aren't diagnostics, so that's not surprising.

> or displaying notes.

What notes?

> We have a peculiar use-case on our end with Fastbuild, where all this was 
> exposed: CPP files are being are preprocessed on one PC, then compiled on 
> another PC (which doesn't have the source-code); then the compiler's stdout 
> is displayed on the first PC.

And what is the final problem? That diagnostics from the compiler's stdout are 
not absolute because they came from the preprocessed code that doesn't include 
the absolute paths?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63648/new/

https://reviews.llvm.org/D63648



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to