thakis added a comment. > So maybe `Driver::IsCLMode()` should take precedence over > `-fdiagnostics-absolute-paths` when using `/showIncludes`?
Definitely not. We want builds to be deterministic; this includes them being independent of the build directory. (This matters for distributed compilation caching.) > So maybe I should also implement `/FC` > <https://docs.microsoft.com/en-us/cpp/build/reference/fc-full-path-of-source-code-file-in-diagnostics?view=vs-2019> > along the way, and make the defaults match between `clang-cl` and `cl`? WDYT? We intentionally don't implement /FC for the same reasons, see the discussion on D23816 <https://reviews.llvm.org/D23816>. If you want absolute paths in the output, you can pass absolute paths to clang-cl and you'll get absolute paths in the output. Does that not work for you? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63648/new/ https://reviews.llvm.org/D63648 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
