jkorous added a comment. Please just update the comment, otherwise LGTM.
================ Comment at: clang/unittests/DirectoryWatcher/DirectoryWatcherTest.cpp:283 /*waitForInitialSync=*/true); + if (!DW) return; ---------------- jkorous wrote: > IIUC this is silently dropping errors. We should print the error here. Ah, my bad - I just took a better look at `Expected<>` and you're right. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65704/new/ https://reviews.llvm.org/D65704 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits