[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

[Saleem Abdulrasool via Phabricator via cfe-commits]

compnerd added inline comments.


================
Comment at: clang/lib/DirectoryWatcher/mac/DirectoryWatcher-mac.cpp:218
+    return llvm::make_error<llvm::StringError>(
+        std::string("Path.empty() error: ") + strerror(errno),
+        llvm::inconvertibleErrorCode());
----------------
compnerd wrote:
> Similar.
Should this just assert as well?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65704/new/

https://reviews.llvm.org/D65704



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits