hokein added a comment. In D67172#1657590 <https://reviews.llvm.org/D67172#1657590>, @ilya-biryukov wrote:
> Also considered moving the std symbol mapping into a separate > (private-to-implementation) class, e.g. we don't use suffix mappings and > symbol mappings outside system includes. > But decided to wait until suffix mapping are going away completely. It took me a while to understand this patch. I'd suggest doing it in this patch as well (it should not require large effort to do it, I think?) The `CanonicalInclude` is becoming complex now, and leading to some wire design (we introduce a new field pointing to another instance). And I'm not sure whether it is possible to remove the suffix mapping completely -- for STL symbols it is possible, but for other symbols like GNU C headers, I didn't find out an automatic way to build a lookup table. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67172/new/ https://reviews.llvm.org/D67172 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits