hokein added inline comments.
================
Comment at: clang-tools-extra/clangd/index/CanonicalIncludes.cpp:780
+ // Prefer a mapping from the system symbols.
+ if (SystemSymbols) {
+ if (auto Result = SystemSymbols->mapHeader(Header, QualifiedName))
----------------
what's the interesting case where `SystemSymbols` is null?
I think it should be fine to always use the standard symbol mapping here? just
use `getStandardSymbolMapping()->mapHeader()`, this would help to simplify the
CanonicalInclude interface (no `addSystemHeadersMapping` and `SystemSymbols`
members are needed).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67172/new/
https://reviews.llvm.org/D67172
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
