tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang/test/Driver/hip-syntax-only.hip:7 + +// CHECK-DAG: clang{{.*}}" "-cc1" {{.*}} "-fcuda-is-device" +// CHECK-DAG: clang{{.*}}" "-cc1" "-triple" "x86_64" ---------------- I'd include `-target <GPU>` and a comment describing that we're making sure that both host and device compilations are still executed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68652/new/ https://reviews.llvm.org/D68652 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits