tra added inline comments.
================
Comment at: clang/test/Driver/hip-syntax-only.hip:7
+
+// CHECK-DAG: clang{{.*}}" "-cc1" {{.*}} "-fcuda-is-device"
+// CHECK-DAG: clang{{.*}}" "-cc1" "-triple" "x86_64"
----------------
hliao wrote:
> tra wrote:
> > I'd include `-target <GPU>` and a comment describing that we're making sure
> > that both host and device compilations are still executed.
> won't -fcuda-is-device be sufficient? that's option specific to device-side
> compilation.
It's sufficient, but we're currently comparing sort of apples
(`-fcuda-is-device`) and oranges (`-triple FOO`) on these two lines. Changing
it into `-triple GPU -fcuda-is-device` vs. `-triple HOST` would make it easier
to understand what's the intent here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68652/new/
https://reviews.llvm.org/D68652
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
