lebedev.ri marked an inline comment as done. lebedev.ri added inline comments.
================ Comment at: clang/lib/Format/Format.cpp:768 LLVMStyle.CommentPragmas = "^ IWYU pragma:"; + LLVMStyle.ConstStyle = FormatStyle::CS_Leave; LLVMStyle.CompactNamespaces = false; ---------------- MyDeveloperDay wrote: > lebedev.ri wrote: > > Based on code reviews, this should be `CS_West`. > I would tend to agree for the LLVM project itself, but I really don't feel I > can change this due to the huge number of projects which have BasedOnStyle: > LLVM (not to mention most other style inherit from LLVM like Google, > Chromium etc...) > > I think this needs to be an opt-in change in the .clang-format (at least for > now) There is already a number of stylistic LLVM-specific decisions in LLVM style * 80-col wrap * pointer alignment to the right * spaces instead of tabs * ??? I think it first and foremost is an LLVM style, and i don't really recall any guarantees that it must not/will not change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D69764 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
