Szelethus added a comment.
Changes to `MallocChecker` really highlight the positive effects of this patch.
Nice!
================
Comment at: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp:451
static ProgramStateRef MallocMemAux(CheckerContext &C, const CallExpr *CE,
- const Expr *SizeEx, SVal Init,
+ const Expr *SizeExpr, SVal Init,
ProgramStateRef State,
----------------
Is it possible to merge these parameters into a single `DynamicSizeInfo` object?
================
Comment at: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp:1167
// elements with zeros in the last one.
- State = MallocMemAux(C, CE, UnknownVal(), UnknownVal(), State,
- AF_IfNameIndex);
+ State = MallocMemAux(C, CE, /*SizeExpr=*/nullptr, UnknownVal(),
+ UnknownVal(), State, AF_IfNameIndex);
----------------
and here?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69726/new/
https://reviews.llvm.org/D69726
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
