NoQ added inline comments.
================ Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/DynamicSize.h:29-31 +/// \returns The stored dynamic size expression for the region \p MR. +const Expr *getDynamicSizeExpr(ProgramStateRef State, const MemRegion *MR); + ---------------- Charusso wrote: > NoQ wrote: > > Why do we need this? > I think as the checkers are growing and we push more-and-more allocation > modeling so that at some point the Git's 8-parameter allocator's size > expression could be retrieved so easily. This is the full arsenal of my > buffer-overflow checker's needs, so I have pushed it here. Also it made a > meaning to have a helper-class with two fields (one would be lame). >>! In D68725#1722136, @NoQ wrote: > any path-sensitive checker for which such region is "interesting" would have > to implement a bug visitor to display the allocation site. Such visitor > automatically knows the location of the `alloca()` expression and can emit > the necessary fixits. >>! In D69813#inline-628182, @NoQ wrote: > Again, you will have to highlight the allocation site with a note. Therefore > you will have to write a bug visitor that traverses the size expression at > some point (or, equivalently, a note tag when the size expression is > evaluated). Therefore you don't need to store the expression in the program > state. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69726/new/ https://reviews.llvm.org/D69726 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
