ABataev added a comment. Again, better to split into 2 patches, one for LLVM and one for clang.
================ Comment at: clang/lib/Sema/SemaOpenMP.cpp:4011 unsigned NamedModifiersNumber = 0; - SmallVector<const OMPIfClause *, OMPC_unknown + 1> FoundNameModifiers( - OMPD_unknown + 1); + SmallVector<const OMPIfClause *, unsigned(OMPC_unknown) + 1> + FoundNameModifiers(unsigned(OMPD_unknown) + 1); ---------------- JonChesterfield wrote: > I wonder if it would be worth wrapping the accesses to FoundNameModifiers in > functor that does the enum class to unsigned conversion. E.g. a class > instance that contains the small vector and exposes operator[] that takes the > enum class. > > FoundNameModifiers[unsigned(val)] is quite a lot of line noise. Why `map`? It can be represented as a simple c-style array without any problems. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69853/new/ https://reviews.llvm.org/D69853 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
