jdoerfert marked 2 inline comments as done.
jdoerfert added inline comments.
================
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:3489
+ !OMPRegionInfo->hasCancel())) {
+ OMPBuilder->CreateBarrier({CGF.Builder.saveIP()}, Kind, ForceSimpleCall,
+ EmitChecks);
----------------
ABataev wrote:
> `createBarrier`
I'd say we align ourselves with the IRBuilder (which has `CreateXXX` methods)
or we are different enough to avoid confusion, e.g., `emitXXXX`. I don't care
much which way but `createXXXX` for one builder and `CreateXXXX` for another
will be confusing, don't you think?
================
Comment at: clang/test/OpenMP/barrier_codegen.cpp:43
+// IRBUILDER: ; Function Attrs: inaccessiblemem_or_argmemonly
+// IRBUILDER-NEXT: declare i32 @__kmpc_global_thread_num(%struct.ident_t*) #2
+
----------------
ABataev wrote:
> Remove `#2`, it may be changed
Agreed, I even added an option to the update_test script to do so but forgot to
use it (D68851).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69922/new/
https://reviews.llvm.org/D69922
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
