ABataev added inline comments.
================
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:3489
+ !OMPRegionInfo->hasCancel())) {
+ OMPBuilder->CreateBarrier({CGF.Builder.saveIP()}, Kind, ForceSimpleCall,
+ EmitChecks);
----------------
jdoerfert wrote:
> ABataev wrote:
> > `createBarrier`
> I'd say we align ourselves with the IRBuilder (which has `CreateXXX` methods)
> or we are different enough to avoid confusion, e.g., `emitXXXX`. I don't care
> much which way but `createXXXX` for one builder and `CreateXXXX` for another
> will be confusing, don't you think?
Shall follow the LLVM coding document and format the new function name in
accordance with it?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69922/new/
https://reviews.llvm.org/D69922
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
