kbobyrev added a comment.

In D71455#1787266 <https://reviews.llvm.org/D71455#1787266>, @MaskRay wrote:

> Renaming `handleDeclOccurence`, `handleMacroOccurence` and  
> `handleModuleOccurence` are definitely not NFC because they are public APIs 
> that can be used by downstream projects.


I'm sorry if it broke some donwstream buildbots for the projects. I thought NFC 
is something that does not change behavior of the code (which is the case in 
this patch?) so is there something else that can make a patch NFC?

Also, if there is anything I could help with (e.g. submitting patches to some 
projects you know are affected by this change) please let me know.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71455/new/

https://reviews.llvm.org/D71455



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to