aaron.ballman added a comment.
Still LG with a small nit in one of the FIXME tests.
================
Comment at: clang-tools-extra/unittests/clang-tidy/AddConstTest.cpp:1006
+}
+
+} // namespace test
----------------
JonasToth wrote:
> aaron.ballman wrote:
> > JonasToth wrote:
> > > aaron.ballman wrote:
> > > > Can you also add some ObjC pointer tests?
> > > i added the most basic test, do you think more is necessary? I don't know
> > > a lot about the objc languages.
> > Ah, those are regular C pointers, not ObjC pointers. I was thinking more
> > along the lines of:
> > ```
> > @class Object;
> > Object *g; // Try adding const to this
> >
> > @interface Inter
> > - (void) foo1: (int *)arg1; // Try adding const to this parameter
> > @end
> > ```
> Well, those don't work well.
> Can i still commit? :) FIXMEs are there.
> Can i still commit? :) FIXMEs are there.
Yes, I think you've still made good progress with the patch as-is. We can
correct the ObjC stuff in a follow-up.
================
Comment at: clang-tools-extra/unittests/clang-tidy/AddConstTest.cpp:1055
+ EXPECT_NE(runCheckOnCode<PointeeRTransform>(Cat(S), nullptr, "input.m"),
+ Cat("Object const*target;"));
+ EXPECT_NE(runCheckOnCode<ValueLTransform>(Cat(S), nullptr, "input.m"),
----------------
The whitespace looks incorrect here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54395/new/
https://reviews.llvm.org/D54395
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
