craig.topper added inline comments.
================ Comment at: clang/lib/CodeGen/CGStmt.cpp:2254 + CGM.getDiags().Report(S.getAsmLoc(), + diag::warn_fe_stack_clash_protection_inline_asm); + } ---------------- serge-sans-paille wrote: > craig.topper wrote: > > Why is this in the frontend diagnostic list? > As far as I understand, that's the only place where line/col accurate > diagnostics are emitted. I was really asking about why we have to use FrontendDiagnostic.h and DriverDiagnostic.h? Is that what we normally use for diagnostics in Codegen files? Seems like a possible layering issue for modules build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68720/new/ https://reviews.llvm.org/D68720 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits