dgoldman marked an inline comment as done. dgoldman added inline comments.
================ Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:653 - Server->addDocument(File, *Contents, WantDiags); + Server->addDocument(File, *Contents, WantDiags, ForceReload); } ---------------- sammccall wrote: > Rather than plumbing this down many levels as yet-another-bool-param, can we > shove it into either ParseInputs or ParseOptions? > e.g. `bool ParseInputs::AllowCached = true;` and set it to false here? > > It's kind of a stretch for the API as we won't make use of it everywhere that > ParseInputs is used, but I think it's better than adding a niche boolean > param everywhere. Done, this cleaned up the tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73916/new/ https://reviews.llvm.org/D73916 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
