zoecarver marked 3 inline comments as done.
zoecarver added inline comments.
================
Comment at: clang/lib/AST/TypePrinter.cpp:1028
+ case UnaryTransformType::RemoveReferenceType:
+ OS << "__remove_reference";
+ print(T->getBaseType(), OS, StringRef());
----------------
These need the opening paren.
================
Comment at: clang/lib/AST/TypePrinter.cpp:1062
case UnaryTransformType::EnumUnderlyingType:
+ case UnaryTransformType::RemoveCV:
+ case UnaryTransformType::RemoveConst:
----------------
Missing `RemoveReference`.
================
Comment at: clang/lib/Parse/ParseDeclCXX.cpp:1105
+void Parser::ParseTypeTransformTypeSpecifier(DeclSpec &DS) {
+ DeclSpec::TST TypeTransformTST = TypeTransformTokToDeclSpec();
+
----------------
I'll work on your comment:
> It would be really cool if we could simplify these conversions to
> static_cast<DeclSpec::TST>(Tok.getKind() - base);
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67052/new/
https://reviews.llvm.org/D67052
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
