kbobyrev added inline comments.
================ Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:326 + // When querying references for a class, clangd's own index will also return + // references of the corresponding class constructors, but this is not true + // for all index backends, e.g. kythe, so we add all constructors to the query ---------------- What about desctructors? Should they always be handled separately? ================ Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:772 +TEST(CrossFileRename, QueryCtorInIndex) { + auto MainCode = Annotations("F^oo f;"); + auto TU = TestTU::withCode(MainCode.code()); ---------------- nit: I think most variables are not being modified here, so maybe const everywhere? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74411/new/ https://reviews.llvm.org/D74411 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits