hokein added inline comments.
================ Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:326 + // When querying references for a class, clangd's own index will also return + // references of the corresponding class constructors, but this is not true + // for all index backends, e.g. kythe, so we add all constructors to the query ---------------- kbobyrev wrote: > What about desctructors? Should they always be handled separately? destructors are fine, there is a type loc of `Foo` class in `~[[Foo]]`, so query the class id can find the reference. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74411/new/ https://reviews.llvm.org/D74411 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
