hokein commandeered this revision. hokein edited reviewers, added: sammccall; removed: hokein. hokein added inline comments.
================ Comment at: clang/lib/AST/TemplateName.cpp:173 +TemplateNameDependence TemplateName::getDependence() const { + auto F = TemplateNameDependence::None; + if (QualifiedTemplateName *QTN = getAsQualifiedTemplateName()) { ---------------- hokein wrote: > This part of refactoring seems a little scary to me, I think it is correct > by comparing with the previous version. but the getDependence() now is very > **complicated**, I have no idea what it is doing. > > instead of merging three different non-trivial if branches into a single > function, maybe keep them as it-is. I have restructured the code, let me know whether it is clear now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71920/new/ https://reviews.llvm.org/D71920 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits