sammccall added inline comments.
================
Comment at: clang/lib/AST/TemplateName.cpp:208
"overloaded templates shouldn't survive to here");
+ D |= TemplateNameDependence::DependentInstantiation;
+ return D;
----------------
hokein wrote:
> sammccall wrote:
> > what's this line about?
> this indicates that the template name is dependent if it doesn't refer to any
> known template declarations (getAsTemplateDecl() returns null). removing it
> will cause a test failure.
oh, I missed the early return in the other case.
nit: I'd suggest a single return and put this in an else { ... }, which I think
makes it slightly clearer that the two "parts" of this function are simply
composed together. Up to you though.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71920/new/
https://reviews.llvm.org/D71920
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
