nickdesaulniers marked an inline comment as done. nickdesaulniers added inline comments.
================ Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:15 -def warn_asm_qualifier_ignored : Warning< - "ignored %0 qualifier on asm">, CatInlineAsm, InGroup<ASMIgnoredQualifier>; -def warn_file_asm_volatile : Warning< - "meaningless 'volatile' on asm outside function">, CatInlineAsm, - InGroup<ASMIgnoredQualifier>; +def err_file_asm_volatile : Error< + "meaningless '%0' on asm outside function">, CatInlineAsm; ---------------- oh, I meant to rename this; and I think flipping the order of this and following def is a little clearer for code review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75563/new/ https://reviews.llvm.org/D75563 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits