sconstab marked 5 inline comments as done. sconstab added inline comments.
================ Comment at: llvm/lib/Target/X86/X86LoadValueInjectionLoadHardening.cpp:271 +// Apply the mitigation to `MF`, return the number of fences inserted. +// If `FixedLoads` is `true`, then the mitigation will be applied to both fixed +// and non-fixed loads; otherwise, only non-fixed loads. ---------------- zbrid wrote: > Am I misunderstanding this comment? It sounds like if FixedLoads is true then > BOTH fixed loads and non-fixed loads will be mitigated. Since > runOnMachineFunction would call hardenLoads twice for non-fixed loads, would > that result in double mitigation for non-fixed loads in the case where we > also harden fixed loads? Unfortunately I'm having trouble reasoning through > this myself, so I'd appreciate some clarification. The comment was incorrect. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75936/new/ https://reviews.llvm.org/D75936 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
