rsmith added a comment.

This needs to be done behind a flag. It's an explicit design goal that 
compilation behavior using a PCH or precompiled preamble behaves identically to 
compilation not using a PCH / precompiled preamble. The behavior of this patch 
is also non-conforming: we're only allowed to perform function template 
instantiations at their points of instantiation (essentially, at points of use 
+ at the end of the translation unit).

I'd be OK with either a (conforming compilation mode) flag that instructs Clang 
to attempt to perform instantiations at the point of use (assuming the template 
is defined at that point), or with a (non-conforming) flag that instructs Clang 
to perform instantiations at the end of the PCH, as it would when compiling a 
header unit.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69585/new/

https://reviews.llvm.org/D69585



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D69585: P... Luboš Luňák via Phabricator via cfe-commits
    • [PATCH] D695... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D695... Luboš Luňák via Phabricator via cfe-commits
    • [PATCH] D695... Richard Smith - zygoloid via Phabricator via cfe-commits

Reply via email to